Discussion:
[PATCH] ata: pata_imx: Use the SIMPLE_DEV_PM_OPS() macro
Fabio Estevam
2014-10-04 12:03:06 UTC
Permalink
From: Fabio Estevam <***@freescale.com>

Using the SIMPLE_DEV_PM_OPS() macro can make the code shorter and cleaner.

Signed-off-by: Fabio Estevam <***@freescale.com>
---
drivers/ata/pata_imx.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
index af42457..989ff5a 100644
--- a/drivers/ata/pata_imx.c
+++ b/drivers/ata/pata_imx.c
@@ -221,13 +221,10 @@ static int pata_imx_resume(struct device *dev)

return 0;
}
-
-static const struct dev_pm_ops pata_imx_pm_ops = {
- .suspend = pata_imx_suspend,
- .resume = pata_imx_resume,
-};
#endif

+static SIMPLE_DEV_PM_OPS(pata_imx_pm_ops, pata_imx_suspend, pata_imx_resume);
+
static const struct of_device_id imx_pata_dt_ids[] = {
{
.compatible = "fsl,imx27-pata",
@@ -244,9 +241,7 @@ static struct platform_driver pata_imx_driver = {
.name = DRV_NAME,
.of_match_table = imx_pata_dt_ids,
.owner = THIS_MODULE,
-#ifdef CONFIG_PM_SLEEP
.pm = &pata_imx_pm_ops,
-#endif
},
};
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tejun Heo
2014-10-05 02:11:11 UTC
Permalink
Post by Fabio Estevam
Using the SIMPLE_DEV_PM_OPS() macro can make the code shorter and cleaner.
Applied to libata/for-3.18. Care to convert other drivers too?

Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Fabio Estevam
2014-10-05 11:32:09 UTC
Permalink
Post by Tejun Heo
Post by Fabio Estevam
Using the SIMPLE_DEV_PM_OPS() macro can make the code shorter and cleaner.
Applied to libata/for-3.18. Care to convert other drivers too?
Yes, I can submit patches for other drivers too. Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...